8000 Add a secrets attribute to the identities collection by stnguyen90 · Pull Request #5966 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ appwrite Public

Add a secrets attribute to the identities collection #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add a secrets attribute to the identities collection #5966

merged 1 commit into from
Aug 9, 2023

Conversation

stnguyen90
Copy link
Contributor
@stnguyen90 stnguyen90 commented Aug 9, 2023 •
edited
Loading

What does this PR do?

These secrets can be used to store data from the provider that may or may not be sensitive.

For example, this will be used by the migration API when connecting to Firebase to store the service account used for the migration.

This data will only be used internally inside Appwrite and not exposed to an end user or developer.

Data here is tied to the user identity so that it can be removed when the user or the user identity is removed.

Test Plan

None

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Add a secrets attribute to the identities collection
14b84ed 
These secrets can be used to store data from the provider that may or
may not be sensitive.

For example, this will be used by the migration API when connecting to
Firebase to store the service account used for the migration.

This data will only be used internally inside Appwrite and not exposed
to an end user or developer.
@stnguyen90 stnguyen90 marked this pull request as ready for review August 9, 2023 15:20
@christyjacob4 christyjacob4 merged commit bef4695 into feat-git-integration Aug 9, 2023
This was referenced Sep 1, 2023
Closed
Closed
@stnguyen90 stnguyen90 deleted the feat-user-identity-secrets branch September 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@PineappleIOnic PineappleIOnic PineappleIOnic approved these changes

@eldadfux eldadfux Awaiting requested review from eldadfux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stnguyen90 @Meldiron @christyjacob4 @PineappleIOnic
0