Fix the default executor host since it's changed in 1.4 #6098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we'll need to change the Dockerfile default as well |
Meldiron
reviewed
Sep 4, 2023
| @@ -748,7 +748,7 @@ | |||
| 'name' => '_APP_EXECUTOR_HOST', | |||
| 'description' => 'The host used by Appwrite to communicate with the function executor!', | |||
| 'introduction' => '0.13.0', | |||
| 'default' => 'http://appwrite-executor/v1', | |||
| 'default' => 'http://executor/v1', | |||
There was a problem hiding this comment.
Looks good, but maybe we should go back to using appwrite-executor, or have smart migration script (if value is exactly http://appwrite-executor/v1, then replace. If not, keep using their modified value)
There was a problem hiding this comment.
let's leave it as executor. smarter installation command coming in: #6137
There was a problem hiding this comment.
@stnguyen90 the override PR has been merged. I think now we should change it back to appwrite-executor
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since the executor's hostname is now
executorappwrite/app/views/install/compose.phtml
Lines 592 to 595 in 36698d1
the default variable value should be updated.
Test Plan
Manual
Related PRs and Issues
None
Checklist