10000 Fix: Untrusted custom domains + auto-ssl by Meldiron · Pull Request #6155 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Untrusted custom domains + auto-ssl #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 6, 2023
Merged

Fix: Untrusted custom domains + auto-ssl #6155

merged 7 commits into from
Sep 6, 2023

Conversation

Meldiron
Copy link
Contributor
@Meldiron Meldiron commented Sep 5, 2023

What does this PR do?

  • Automatically issues SSL for first domain connected to new instance
  • Servers API+Console by default, if domain is not known

Test Plan

  • Manual QA

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

christyjacob4
christyjacob4 reviewed Sep 6, 2023
View reviewed changes
@christyjacob4 christyjacob4 merged commit 67698cc into 1.4.x Sep 6, 2023
@stnguyen90 stnguyen90 deleted the fix-unknown-domains branch September 6, 2023 18:54
@stnguyen90 stnguyen90 added this to the 1.4.2 milestone Sep 6, 2023
@stnguyen90 stnguyen90 linked an issue Sep 7, 2023 that may be closed by this pull request
🐛 Bug Report: default OAuth on custom domain results in 404 error #6124
Closed
2 tasks
This was referenced Oct 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.4 release
Status: Done
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: default OAuth on custom domain results in 404 error
3 participants
@Meldiron @christyjacob4 @stnguyen90
0