8000 Added Hacktoberfest Contributing Guidelines by Haimantika · Pull Request #6509 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added Hacktoberfest Contributing Guidelines #6509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 11, 2023
Merged

Added Hacktoberfest Contributing Guidelines #6509

merged 10 commits into from
Oct 11, 2023

Conversation

Haimantika
Copy link
Contributor

What does this PR do?

Adds Hacktoberfest Contributing Guidelines

Test Plan

NA

Related PRs and Issues

NA

Checklist

  • Have you read the Contributing Guidelines on issues?
  • [] If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

sc231997
sc231997 reviewed Oct 6, 2023
View reviewed changes
gewenyu99
gewenyu99 suggested changes Oct 6, 2023
View reviewed changes
stnguyen90
stnguyen90 requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor
@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename also doesn't quite match any of our other files. Maybe it can be called HACKTOBERFEST.md?

Haimantika and others added 3 commits October 9, 2023 22:41
@Haimantika
Copy link
Contributor Author

The filename also doesn't quite match any of our other files. Maybe it can be called HACKTOBERFEST.md?

@stnguyen90 all fixed now

@Haimantika Haimantika requested a review from stnguyen90 October 9, 2023 17:27
stnguyen90
stnguyen90 requested changes Oct 10, 2023
View reviewed changes
@Haimantika Haimantika requested a review from stnguyen90 October 10, 2023 18:21
stnguyen90
stnguyen90 requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor
@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't addressed:

  1. https://github.com/appwrite/appwrite/pull/6509/files#r1353047362
  2. https://github.com/appwrite/appwrite/pull/6509/files#r1353051558
  3. Added Hacktoberfest Contributing Guidelines #6509 (comment)

Haimantika and others added 3 commits October 11, 2023 00:42
@Haimantika @stnguyen90
Update HACKTOBERFEST.md
42da578 
Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>
@Haimantika
Update HACKTOBERFEST.md
d70042b
@Haimantika
Update HACKTOBERFEST.md
dbf3f63
@Haimantika Haimantika requested a review from stnguyen90 October 10, 2023 19:22
@christyjacob4 christyjacob4 merged commit 32c8e84 into main Oct 11, 2023
@stnguyen90 stnguyen90 deleted the fix-add-hacktoberfest-contributing-guidelines branch October 23, 2023 20:57
This was referenced Nov 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc231997 sc231997 sc231997 left review comments

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@gewenyu99 gewenyu99 gewenyu99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Haimantika @stnguyen90 @sc231997 @gewenyu99 @christyjacob4
0