Add twoWayKey checks and multiple many-to-many restrictions #7153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fogelito
commented
Nov 16, 2023
stnguyen90
reviewed
Feb 12, 2024
app/controllers/api/databases.php
Outdated
Comment on lines
1682
to
1689
| if ( | ||
| $type === Database::RELATION_MANY_TO_MANY && | ||
| $attribute->getAttribute('type') === Database::VAR_RELATIONSHIP && | ||
| $attribute->getAttribute('options')['relationType'] === Database::RELATION_MANY_TO_MANY && | ||
| $attribute->getAttribute('options')['relatedCollection'] === $relatedCollection->getId() | ||
| ) { | ||
| throw new Exception(Exception::ATTRIBUTE_ALREADY_EXISTS, 'Creating more than one "manyToMany" relationship on the same collection is currently not permitted.'); | ||
| } |
There was a problem hiding this comment.
Currently we do not have this option in Utopia , Definitely something to improve in the future.
The issue you mention here sounds like the reason we are restricting this for now.
abnegate
reviewed
Feb 25, 2024
� Conflicts: � composer.lock
abnegate
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for relations attributes when twoWayKey variable is not passed in API,
We do not want the worker to throw the Error
Until now, it was checked only for twoWay = true
Added a validation to prevent the creation of 2 manyToMany relations between the same collections
#6281