8000 Feat upgrade php version (8.0) by eldadfux · Pull Request #713 · appwrite/appwrite · GitHub

More Web Proxy on the site http://driver.im/

Feat upgrade php version (8.0) #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eldadfux merged 140 commits into 0.8.x from feat-upgrade-php-version

Apr 29, 2021

Member

eldadfux commented

What does this PR do?

Upgrading PHP version from 7.4 to 8.0. Currently using RC2 version.

Test Plan

Using current tests.

Related PRs and Issues

None.

Have you read the [Contributing Guidelines on issues]

Yes

eldadfux added 6 commits

October 27, 2020 08:20


          Upgraded to php8

be33726


          Updated PDO PHP8 signature

e5c5cb0


          Fix for PHP8 array_push

cb82657


          Fixed reference

745860a


          Merge branch '0.7.x' of github.com:appwrite/appwrite into feat-upgrad…

38e52ea

…e-php-version


          Fixed mock params

146046a

eldadfux changed the base branch from master to 0.7.x

October 27, 2020 16:12

eldadfux requested review from TorstenDittmann, christyjacob4 and SoftCreatR

October 27, 2020 16:13


          Merge branch '0.7.x' of github.com:appwrite/appwrite into feat-upgrad…

e8fb016

…e-php-version

SoftCreatR reviewed

View reviewed changes

Contributor

SoftCreatR left a comment

Not really a problem, but you are attempting to install docker-cli twice (line 136 & 141 in Dockerfile).

src/Appwrite/Extend/PDOStatement.php Show resolved Hide resolved


          Removed multiple docker-cli setups

8bbdac2

Member Author

eldadfux commented

Not really a problem, but you are attempting to install docker-cli twice (line 136 & 141 in Dockerfile).

Fixed 👌🏻


          Added missing docs

SoftCreatR reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

SoftCreatR reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

eldadfux added 2 commits

October 27, 2020 23:56


          New line :)

42d9a64


          Merge branch '0.7.x' into feat-upgrade-php-version

8d60a6a

SoftCreatR reviewed

View reviewed changes

Dockerfile Show resolved Hide resolved

SoftCreatR reviewed

View reviewed changes

Dockerfile Show resolved Hide resolved

eldadfux added 2 commits

October 29, 2020 00:34


          Removed imagemagick dev

eb9730b


          Merge branch 'feat-upgrade-php-version' of github.com:appwrite/appwri…

47255f1

…te into feat-upgrade-php-version

SoftCreatR approved these changes

View reviewed changes

TorstenDittmann approved these changes

View reviewed changes

Contributor

TorstenDittmann left a comment

Some changes are a bit beyond my PHP horizon, but I can't see anything that catches my eye.

Member Author

eldadfux commented

Thanks for all the help @SoftCreatR and @TorstenDittmann!

I'll wait for the official release before finally merging this PR.

eldadfux added 4 commits

October 31, 2020 07:43


          Merge branch '0.7.x' of github.com:appwrite/appwrite into feat-upgrad…

608cf36

…e-php-version


          Merge branch '0.7.x' of github.com:appwrite/appwrite into feat-upgrad…

6cdeaac

…e-php-version


          Merge branch '0.7.x' of github.com:appwrite/appwrite into feat-upgrad…

de4ea2a

…e-php-version


          Merge branch '0.7.x' of github.com:appwrite/appwrite into feat-upgrad…

46ae720

…e-php-version

TorstenDittmann added 23 commits

April 27, 2021 08:55


          fix: breaking deps

ee9a041


          tests: reorder tests

a21bb8d


          chore: updated changelog

c905803


          chore: upgrade MaxMind-DB-Reader to 1.10.1

ab325bf


          tests: debug influxdb

1c8be29


          tests: try different influxdb

b747c5c


          tests: fix typo

d775b17


          tests: revert influxdb image

acbf643


          fix: influx db client

5ddcdf1


          Revert "fix: influx db client"

4689d0b

This reverts commit 5ddcdf1.


          tests: re-arrange order

1ce0536


          tests: add sleep before project usage test

c557e6c


          tests: debug travis

107bbf5


          tests: adjust curl

ef7c454


          tests: adjust curl

0ddefb9


          tests: remove debug

c3bf481


          tests: remove docker-compose upgrade

86c7ff7


          tests: revert debug changes

c2a3d52


          tests: only use php-8.0 for runtimes

7ddf277


          tests: add travis prepare script

ebd41c7


          tests: clean up travis file

cac9875


          chore: fix whitespace in travis file

53526d4


          Merge branch '0.8.x' of https://github.com/appwrite/appwrite into fea…

24705f2

…t-upgrade-php-version

eldadfux commented

View reviewed changes

.travis-ci/prepare.sh Outdated Show resolved Hide resolved

CHANGES.md Outdated Show resolved Hide resolved

app/workers/functions.php Outdated Show resolved Hide resolved

app/workers/webhooks.php Outdated Show resolved Hide resolved

docker-compose.yml Outdated Show resolved Hide resolved


          fix: adapt to review

6a19671

eldadfux commented

View reviewed changes

app/config/variables.php Show resolved Hide resolved

TorstenDittmann added 2 commits

April 29, 2021 17:20


          fix: deprecation notice for

d58cc60


          fix: cloud functions

5e4b335

eldadfux merged commit 5aad3f7 into 0.8.x

eldadfux deleted the feat-upgrade-php-version branch

May 15, 2021 07:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0