Add a flag to install and upgrade commands to not start Appwrite #7271
Conversation
Sorry, something went wrong.
This can be useful for cases where the developer only wants the files to be generated and doesn't want to start Appwrite.
| @@ -29,10 +30,11 @@ public function __construct() | |||
| ->param('organization', 'appwrite', new Text(0), 'Docker Registry organization', true) | |||
| ->param('image', 'appwrite', new Text(0), 'Main appwrite docker image', true) | |||
| ->param('interactive', 'Y', new Text(1), 'Run an interactive session', true) | |||
| ->callback(fn ($httpPort, $httpsPort, $organization, $image, $interactive) => $this->action($httpPort, $httpsPort, $organization, $image, $interactive)); | |||
| ->param('noStart', false, new Boolean(true), 'Run an interactive session', true) | |||
There was a problem hiding this comment.
Should this be camelCase or dash-case?
There was a problem hiding this comment.
I did camel because httpPort and httpsPort are camelCase. That said, in CLIs dash-case is more common.
There was a problem hiding this comment.
Will it be a breaking change if we adapt our style? do we have inconsistencies in other places?
There was a problem hiding this comment.
Yes, it'll be a breaking change if people are using these scripts and passing the params camelCase. We would have to update utopia-php/cli to support both camelCase and dash-case for backwards compatbility.
This is the only command that has multiple words so it's the only one that has camelCase.
There was a problem hiding this comment.
Eldad said:
if we correct the styling and update the docs, the impact should be 0 for current users. Any reasons not to fix it?
@eldadfux, if someone has some script that uses the old syntax, it will break. I do agree the impact is small, though. That said, I've updated the arguments. Here's the test:
Kebab case like --http-port is much more common in CLIs than --httpPort.
This can be useful for cases where the developer only wants the files to be generated and doesn't want to start Appwrite.
What does this PR do?
Closes #7223
Test Plan
Manually ran install:
Manually ran upgrade:
Related PRs and Issues
Checklist