8000 Update the delete identity endpoints to set the params and payload by stnguyen90 · Pull Request #7348 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the delete identity endpoints to set the params and payload #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

Update the delete identity endpoints to set the params and payload #7348

merged 1 commit into from
Jan 9, 2024

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

Because no payload was set, the event params (userId and identityId) wasn't picked up automatically. This updates the endpoints so that the payload is set, but also makes sure to set the userId and identityId params since the identityId param's key doesn't match the key in the payload.

Test Plan

Tested by deleting an identity and ensuring no error was thrown in the logs.

Related PRs and Issues

None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Update the delete identity endpoints to set the params and payload
8000
f1ba7b0 
Because no payload was set, the event params (userId and identityId)
wasn't picked up automatically. This updates the endpoints so that the
payload is set, but also makes sure to set the userId and identityId
params since the identityId param's key doesn't match the key in the
payload.
@stnguyen90 stnguyen90 requested a review from eldadfux December 27, 2023 23:38
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@eldadfux eldadfux merged commit b0a8aac into main Jan 9, 2024
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
@stnguyen90 stnguyen90 deleted the fix-delete-identity-event branch April 25, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @eldadfux
0