8000 fix for file extension not supported by lohanidamodar · Pull Request #7349 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix for file extension not supported #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2023
Merged

fix for file extension not supported #7349

merged 3 commits into from
Dec 28, 2023

Conversation

lohanidamodar
Copy link
Member
@lohanidamodar lohanidamodar commented Dec 28, 2023 •
edited
Loading
  • the error occured with jfif extension, which is essentially a jpeg file

What does this PR do?

  • Fixes file preview when default file extension is not one of supported ones but has supported mime/type and output format is not provided (occurred with .jfif image which has mime type of image/jpeg)

Test Plan

  • Update storage test to include test for this case

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@lohanidamodar
fix for file extension not supported
e8ff828 
- the error occured with jfif extension, which is essentially a jpeg file
@lohanidamodar
fix formatting
94a18ed
@lohanidamodar
update tests for preview
83a009d
eldadfux
eldadfux reviewed Dec 28, 2023
View reviewed changes
@eldadfux eldadfux merged commit 86ce7a3 into main Dec 28, 2023
@lohanidamodar lohanidamodar deleted the pea-32-fix-preview-output branch December 28, 2023 09:40
This was referenced Jan 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lohanidamodar @eldadfux
0