10000 Fix app console hostnames check by stnguyen90 · Pull Request #7385 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix app console hostnames check #7385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix app console hostnames check #7385

merged 2 commits into from
Jan 3, 2024

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

Test Plan

Tests should pass

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Add changes from previous console platforms variable PR
06e385b 
See #4581
@stnguyen90
Fix _APP_CONSOLE_HOSTNAMES check
faf39fc 
Ensure invalid hostnames such as empty strings are not added as a
hostname.
@stnguyen90 stnguyen90 force-pushed the fix-app-console-hostnames-check branch from 8d8538e to faf39fc Compare January 3, 2024 19:30
@stnguyen90 stnguyen90 marked this pull request as ready for review January 3, 2024 20:02
@stnguyen90 stnguyen90 mentioned this pull request Jan 3, 2024
Closed
1 task
@TorstenDittmann TorstenDittmann merged commit 6b1330e into 1.4.x Jan 3, 2024
@TorstenDittmann TorstenDittmann deleted the fix-app-console-hostnames-check branch January 3, 2024 20:28
@stnguyen90 stnguyen90 mentioned this pull request Jan 3, 2024
Merged
2 tasks
This was referenced Feb 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @TorstenDittmann
0