8000 1.5 QA bug fixes by Meldiron · Pull Request #7495 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1.5 QA bug fixes #7495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

1.5 QA bug fixes #7495

wants to merge 10 commits into from

Conversation

Meldiron
Copy link
Contributor
@Meldiron Meldiron commented Jan 26, 2024

What does this PR do?

  • Removes no longer needed translations
  • Fixes unwanted empty spaces in email copy about client device
  • Blocks email otp if disabled on project
  • Fixes nested templates and problematic plaintext mails
  • Fixes unescaped HTML in magic URL & email otp mails

Test Plan

  • Manual QA

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@Meldiron Meldiron changed the title Fix: Email OTP bugs 1.5 QA bug fixes Jan 26, 2024
@@ -31,6 +31,12 @@
}
break;

case 'emailOtp':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call it email-otp so it aligns with the other values like magic-url?

@eldadfux eldadfux added product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. version / 1.5 labels Feb 18, 2024
@stnguyen90 stnguyen90 marked this pull request as draft March 20, 2024 22:29
@stnguyen90
Copy link
Contributor

@Meldiron, is this PR still needed?

@stnguyen90
Copy link
Contributor

I'm closing this stale issue. Please create issues to track anything that still needs to be done.

@stnguyen90 stnguyen90 closed this May 3, 2024
7691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants
0