8000 Fix webhooks failed connection by stnguyen90 · Pull Request #7848 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix webhooks failed connection #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix webhooks failed connection #7848

merged 1 commit into from
Mar 20, 2024

Conversation

stnguyen90
Copy link
Contributor
@stnguyen90 stnguyen90 commented Mar 19, 2024 •
edited
Loading

What does this PR do?

Add DB env vars to webhook worker since every worker requires the DB env vars because a connection is created on init.

Fixes: #7844

Test Plan

Confirmed installing creates a docker-compose.yml file with the DB vars in the webhook's environments:

Screen Shot 2024-03-19 at 3 50 55 PM

Confirmed triggering a webhook event fires sucessfully.

Screen Shot 2024-03-19 at 4 09 41 PM

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
fix(webhooks): add DB env vars to webhook worker
5eff245 
Every worker requires the DB env vars because a connection is created on init.
@stnguyen90 stnguyen90 marked this pull request as ready for review March 20, 2024 00:09
@christyjacob4 christyjacob4 merged commit 7f5a890 into 1.5.x Mar 20, 2024
@christyjacob4 christyjacob4 deleted the fix-7844-webhooks-failed-connection branch March 20, 2024 05:53
@eldadfux eldadfux mentioned this pull request Mar 21, 2024
Closed
2 tasks
@mbackonja mbackonja mentioned this pull request Apr 22, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @christyjacob4
0