8000 Validate cursor value by fogelito · Pull Request #8108 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Validate cursor value #8108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 356 commits into from
Closed

Validate cursor value #8108

wants to merge 356 commits into from

Conversation

fogelito
Copy link
Contributor
@fogelito fogelito commented May 9, 2024
  • Add validation for cursors
  • Fixes this error: Utopia\Database\Database::getDocument(): Argument Added Follow on StackShare badge #2 ($id) must be of type string, null given, called in /usr/src/code/vendor/appwrite/server-ce/app/controllers/api/databases.php on line 3011

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

abnegate and others added 30 commits March 13, 2024 19:10
Fix membership query to use internalId
It's done automatically when setting the params already.
Execution via domain should be blocked if permissions does not contain
any and permissions does not contain guests.
abnegate and others added 29 commits May 7, 2024 17:29
Ensure namespace is set if override equals shared tables
Disable sending realtime stats because the $database->find('realtime')
is throwing:

> Cannot execute queries while other unbuffered queries are active.

In addition, the realtime stats are not being collected so there's no
point in having this enabled.
Fix project deletes for shared tables
SQL can throw an error where the code is a string like 'HY000', but
$server->close() expects an integer. This change ensures we only pass
an integer into $server->close().
Handle SQL error code 'HY000' in realtime
@fogelito fogelito closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0