Add support for scheduled executions #8243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
commented
Jun 12, 2024
Meldiron
commented
Jun 12, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 17, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jun 26, 2024
Meldiron
commented
Jul 1, 2024
eldadfux
requested changes
Jul 2, 2024
abnegate
reviewed
Jul 3, 2024
Comment on lines
+4553
to
+4563
| [ | ||
| '$id' => ID::custom('data'), | ||
| 'type' => Database::VAR_STRING, | ||
| 'format' => '', | ||
| 'size' => 65535, | ||
| 'signed' => true, | ||
| 'required' => false, | ||
| 'default' => new \stdClass(), | ||
| 'array' => false, | ||
| 'filters' => ['json', 'encrypt'], | ||
| ], |
There was a problem hiding this comment.
Will we need a migration for this?
There was a problem hiding this comment.
We need to add a column, but it doesn't require migration - patch script is enough. Like we did for some billing columns and tables.
Comment on lines
+1775
to
+1785
| $dbForConsole->createDocument('schedules', new Document([ | ||
| 'region' => System::getEnv('_APP_REGION', 'default'), | ||
| 'resourceType' => 'execution', | ||
| 'resourceId' => $execution->getId(), | ||
| 'resourceInternalId' => $execution->getInternalId(), | ||
| 'resourceUpdatedAt' => DateTime::now(), | ||
| 'projectId' => $project->getId(), | ||
| 'schedule' => $scheduledAt, | ||
| 'data' => $data, | ||
| 'active' => true, | ||
| ])); |
There was a problem hiding this comment.
If logging is false for the function, we'll create a schedule, but the execution won't exist
There was a problem hiding this comment.
In another PR, for 1.6, we are making it so logging=false still creates document. We can ignore this bug, as it wont be there once all PRs are merged.
lohanidamodar
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds parameter to
createExecutionto allow execution in the future, similarly to how messages can also be scheduled for later.Fixes #5489
Test Plan
Related PRs and Issues
Checklist