8000 Track project last activity by lohanidamodar · Pull Request #8366 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Track project last activity #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 16, 2024
Merged

Track project last activity #8366

merged 10 commits into from
Jul 16, 2024

Conversation

lohanidamodar
Copy link
Member
@lohanidamodar lohanidamodar commented Jul 8, 2024 •
edited
Loading

What does this PR do?

  • Adds accessed at attribute to project that updates once every 24 hours
  • Needs patch to create this attribute for migration

Test Plan

  • Same as accessedAt attribute in users
  • Tested manually, as this is not included in response model

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@lohanidamodar lohanidamodar marked this pull request as ready for review July 9, 2024 02:16
@lohanidamodar lohanidamodar changed the base branch from main to 1.6.x July 10, 2024 03:07
@lohanidamodar lohanidamodar changed the b 8000 ase branch from 1.6.x to main July 10, 2024 04:49
@lohanidamodar lohanidamodar changed the base branch from main to 1.6.x July 10, 2024 07:12
@lohanidamodar lohanidamodar requested a review from Meldiron July 10, 2024 07:16
christyjacob4
christyjacob4 reviewed Jul 15, 2024
View reviewed changes
app/controllers/api/projects.php Outdated
@@ -22,6 +22,7 @@
use Utopia\Cache\Cache;
use Utopia\Config\Config;
use Utopia\Database\Database;
use Utopia\Database\DateTime as DatabaseDateTime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use Utopia\Database\DateTime as DatabaseDateTime;
use Utopia\Database\DateTime;

Can we just not use this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

christyjacob4
christyjacob4 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member
@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small comment

@christyjacob4 christyjacob4 merged commit 275552f into 1.6.x Jul 16, 2024
23 checks passed
@christyjacob4 christyjacob4 deleted the feat-project-accessed-at branch July 16, 2024 07:35
@stnguyen90 stnguyen90 changed the title Feat project last activity Track project last activity Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@stnguyen90 stnguyen90 Awaiting requested review from stnguyen90

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lohanidamodar @Meldi 335B ron @christyjacob4
0