Update delete authenticator to remove OTP Validation #8367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorstenDittmann
approved these changes
Jul 8, 2024
stnguyen90
reviewed
Jul 9, 2024
docs/examples/1.5.x/client-rest/examples/account/delete-mfa-authenticator.md
Show resolved
Hide resolved
abnegate
reviewed
Jul 10, 2024
| @@ -3958,12 +3958,11 @@ function sendSessionAlert(Locale $locale, Document $user, Document $project, Doc | |||
| ->label('sdk.response.code', Response::STATUS_CODE_NOCONTENT) | |||
| ->label('sdk.response.model', Response::MODEL_NONE) | |||
| ->param('type', null, new WhiteList([Type::TOTP]), 'Type of authenticator.') | |||
| ->param('otp', '', new Text(256), 'Valid verification token.') | |||
There was a problem hiding this comment.
We'll need a request filter for this removal
abnegate
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the delete authenticator endpoint to no longer need a challenge verification and to instead make it a
mfaProtectedroute so only recently authorised sessions can delete an authenticator.This PR also generates the documentation for 1.6.x and adds the spec files.
Related PRs and Issues
Checklist