8000 Fix domain check by ItzNotABug · Pull Request #8472 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix domain check #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix domain check #8472

merged 1 commit into from
Aug 8, 2024

Conversation

ItzNotABug
Copy link
Member

What does this PR do?

If the value of _APP_DOMAIN_FUNCTIONS is empty, the proxy check via str_ends_with always returns true. This PR fixes it.

Test Plan

Manual.

Related PRs and Issues

N/A.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 self-requested a review August 5, 2024 13:56
@stnguyen90 stnguyen90 merged commit 6410b20 into appwrite:main Aug 8, 2024
23 of 24 checks passed
@ItzNotABug ItzNotABug deleted the fix-proxy-rules-check branch August 8, 2024 06:07
@stnguyen90 stnguyen90 changed the title Fix Domain Check Fix domain check Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItzNotABug @stnguyen90
0