Add ci/cd benchmark #8414
Merged
Add ci/cd benchmark #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Benchmark results
|
✨ Benchmark results
|
✨ Benchmark results
⚡ Benchmark results
|
✨ Benchmark results
⚡ Benchmark Compering
|
✨ Benchmark results
⚡ Benchmark Compering
|
christyjacob4
approved these changes
Jul 18, 2024
8000
✨ Benchmark results
⚡ Benchmark Comparison
|
.github/workflows/benchmark.yml
Outdated
Comment on lines
3
to
6
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
Can we make this a little more optimal and make the benchmark part of the existing tests here https://github.com/appwrite/appwrite/blob/main/.github/workflows/tests.yml#L41-L47
That way we already have the image built and saved in cache.
We can add a new job called benchmark that uses the cached image from the setup job.
✨ Benchmark results
⚡ Benchmark Comparison
|
✨ Benchmark results
⚡ Benchmark Comparison
|
✨ Benchmark results
⚡ Benchmark Comparison
|
✨ Benchmark results
⚡ Benchmark Comparison
|
christyjacob4
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding CI/CD benchmark on PR