10000 chore: Changes for console roles support by lohanidamodar · Pull Request #8565 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Changes for console roles support #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Oct 1, 2024
Merged

Conversation

lohanidamodar
Copy link
Member
@lohanidamodar lohanidamodar commented Aug 21, 2024

What does this PR do?

  • Improve auth checks for console membership checks
  • Improve membership endpoint for console roles support

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link
github-actions bot commented Aug 21, 2024

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

@lohanidamodar lohanidamodar changed the base branch from 1.5.x to 1.6.x September 4, 2024 07:37
Copy link
github-actions bot commented Sep 4, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 4, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 4, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 4, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

1 similar comment
Copy link
github-actions bot commented Sep 4, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 4, 2024

✨ Benchmark results

  • Requests per second: 1,089
  • Requests with 200 status code: 196,089
  • P99 latency: 0.094256304

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,089 1,638
200 196,089 294,875
P99 0.094256304 0.070330707

Copy link
github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

1 similar comment
Copy link
github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Sep 5, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
pyc 3.11.9-r0 CVE-2024-6232 HIGH
pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3 3.11.9-r0 CVE-2024-6232 HIGH
python3 3.11.9-r0 CVE-2024-7592 HIGH
python3-pyc 3.11.9-r0 CVE-2024-6232 HIGH
python3-pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-6232 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-7592 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
pyc 3.11.9-r0 CVE-2024-6232 HIGH
pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3 3.11.9-r0 CVE-2024-6232 HIGH
python3 3.11.9-r0 CVE-2024-7592 HIGH
python3-pyc 3.11.9-r0 CVE-2024-6232 HIGH
python3-pyc 3.11.9-r0 CVE-2024-7592 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-6232 HIGH
python3-pycache-pyc0 3.11.9-r0 CVE-2024-7592 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Comment on lines 277 to 279
/**
* Admin User Authentication
*/ elseif (($project->getId() === 'console' && !$team->isEmpty() && !$user->isEmpty()) || ($project->getId() !== 'console' && !$user->isEmpty() && $mode === APP_MODE_ADMIN)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the formatting/ indentation here ?

@christyjacob4 christyjacob4 merged commit c610c9a into 1.6.x Oct 1, 2024
26 checks passed
@christyjacob4 christyjacob4 deleted the feat-console-roles-dl branch October 1, 2024 15:20
@christyjacob4 christyjacob4 mentioned this pull request Dec 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0