8000 Pretty print specs by Meldiron · Pull Request #8643 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pretty print specs #8643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 10, 2024
Merged

Pretty print specs #8643

merged 4 commits into from
Sep 10, 2024

Conversation

Meldiron
Copy link
Contributor
@Meldiron Meldiron commented Sep 8, 2024

What does this PR do?

Pretty-prints specs to make them more readable and prevent unnessessery merge conflicts.

Test Plan

  • Existing tests must pass
  • Files are pretty-printed

CleanShot 2024-09-08 at 09 26 19@2x

  • Re-running specs generation doesn't cause changes
    CleanShot 2024-09-08 at 09 24 36@2x

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 8, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 8, 2024

✨ Benchmark results

  • Requests per second: 1,756
  • Requests with 200 status code: 316,084
  • P99 latency: 0.079050228

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,756 1,782
200 316,084 320,853
P99 0.079050228 0.079216817

@christyjacob4 christyjacob4 merged commit a00c771 into 1.6.x Sep 10, 2024
5 of 6 checks passed
@christyjacob4 christyjacob4 deleted the chore-prettyprint-specs branch September 10, 2024 10:52
@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libexpat 2.6.2-r0 CVE-2024-45490 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45491 CRITICAL
libexpat 2.6.2-r0 CVE-2024-45492 CRITICAL
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL
stdlib 1.21.11 CVE-2024-34156 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@stnguyen90 stnguyen90 changed the title Chores: Prettyprint specs Pretty print specs Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meldiron @christyjacob4
0