8000 Fix domain execution stats by PineappleIOnic · Pull Request #8608 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix domain execution stats #8608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 2, 2024
Merged

Fix domain execution stats #8608

merged 6 commits into from
Sep 2, 2024

Conversation

PineappleIOnic
Copy link
Contributor
@PineappleIOnic PineappleIOnic commented Sep 2, 2024 •
edited by stnguyen90
Loading

What does this PR do?

This PR fixes the bandwidth metrics for custom domain executed functions and adds tests to confirm this is working as expected.

Related

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,643
  • Requests with 200 status code: 295,811
  • P99 latency: 0.081509705

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,643 1,683
200 295,811 303,004
P99 0.081509705 0.08199605

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

1 similar comment
@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!
8000

@github-actions GitHub Actions
Copy link
github-actions bot commented Sep 2, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
py3-setuptools 68.2.2-r0 CVE-2024-6345 HIGH
py3-setuptools-pyc 68.2.2-r0 CVE-2024-6345 HIGH
github.com/docker/docker v27.1.0+incompatible CVE-2024-41110 CRITICAL

Source Code Scan Results

🎉 No vulnerabilities found!

@abnegate abnegate merged commit 74c4478 into 1.6.x Sep 2, 2024
25 checks passed
@abnegate abnegate deleted the fix-domain-execution-stats branch September 2, 2024 11:18
@stnguyen90 stnguyen90 linked an issue Sep 3, 2024 that may be closed by this pull request
🐛 Bug Report: Executions count and bandwidth not incremented when executing function domain #8339
Closed
2 tasks
@stnguyen90 stnguyen90 mentioned this pull request Nov 7, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Executions count and bandwidth not incremented when executing function domain
2 participants
@PineappleIOnic @abnegate
0