Fix logging behaviour for Functions #8627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
| // Preparations: Create Function | ||
| $folder = 'node'; | ||
| $code = realpath(__DIR__ . '/../../../resources/functions') . "/$folder/code.tar.gz"; | ||
| $this->packageCode($folder); |
There was a problem hiding this comment.
lets make use of an existing test to just add the logging attribute. adding a whole new test for this will keep adding overhead to the test times. functions tests already takes the longest
christyjacob4
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that function with logging=false still always makes execution, just doesn't have logs and errors
Test Plan
Related PRs and Issues
x
Checklist