8000 chore: remove db disk storage calculation by christyjacob4 · Pull Request #8745 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove db disk storage calculation #8745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore: remove db disk storage calculation #8745

merged 2 commits into from
Oct 1, 2024

Conversation

christyjacob4
Copy link
Member
@christyjacob4 christyjacob4 commented Oct 1, 2024 •
edited
Loading

What does this PR do?

Remove the storage_disk metric due to performance issues when computing the table size using

SELECT (FS_BLOCK_SIZE + ALLOCATED_SIZE) size FROM INFORMATION_SCHEMA.INNODB_TABLESPACES WHERE NAME = 'appwrite/_146495_stats';

Test Plan

Manually verified that the metrics are being recorded correctly

Screenshot 2024-10-01 at 11 06 46 PM

Screenshot 2024-10-01 at 11 09 55 PM

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?
8000

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 1, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

TorstenDittmann
TorstenDittmann reviewed Oct 1, 2024
View reviewed changes
fogelito
fogelito approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor
@fogelito fogelito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 1, 2024

✨ Benchmark results

  • Requests per second: 1,084
  • Requests with 200 status code: 195,241
  • P99 latency: 0.093039546

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,084 1,618
200 195,241 291,341
P99 0.093039546 0.07067061

@christyjacob4 christyjacob4 merged commit 1abd096 into 1.6.x Oct 1, 2024
25 checks passed
@christyjacob4 christyjacob4 deleted the update-database-metrics branch October 1, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann left review comments

@fogelito fogelito fogelito approved these changes

@shimonewman shimonewman shimonewman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christyjacob4 @TorstenDittmann @fogelito @shimonewman
0