8000 Remove JPEG fallback for webp by lohanidamodar · Pull Request #8746 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove JPEG fallback for webp #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

lohanidamodar
Copy link
Member
@lohanidamodar lohanidamodar commented Oct 2, 2024

What does this PR do?

  • Now that safari supports webp but without the appropriate header, remove the fallback

Fixes #6976

Test Plan

  • Manual test in safari

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

- Now that safari supports webp but without the appropriate header, remove the fallback
Copy link
github-actions bot commented Oct 2, 2024

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Oct 2, 2024

✨ Benchmark results

  • Requests per second: 1,099
  • Requests with 200 status code: 197,799
  • P99 latency: 0.093180684

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,099 1,663
200 197,799 299,454
P99 0.093180684 0.069526276

@lohanidamodar lohanidamodar merged commit 36aa38c into 1.6.x Oct 2, 2024
24 of 25 checks passed
@lohanidamodar lohanidamodar deleted the fix-remove-jpeg-fallback branch October 2, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0