8000 Move createDocument from api to worker by vermakhushboo · Pull Request #8776 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move createDocument from api to worker #8776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

vermakhushboo
Copy link
Member
@vermakhushboo vermakhushboo commented Oct 9, 2024

What does this PR do?

Move the logic to create document in case of sync domain executions from API in general.php to functions worker to not block the API in case the worker gets frozen due to a deadlock

For reference, current speed of Deno 2.0 starter is :

CleanShot 2024-10-14 at 11 53 31@2x

slapper -targets end.tx -minY 100ms -maxY 500ms

Test Plan

  • Manual QA domain execution still creates document:

CleanShot 2024-10-14 at 11 57 30@2x
CleanShot 2024-10-14 at 11 57 27@2x

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link
github-actions bot commented Oct 9, 2024

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link
github-actions bot commented Oct 9, 2024

✨ Benchmark results

  • Requests per second: 1,068
  • Requests with 200 status code: 192,320
  • P99 latency: 0.094891903

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,068 1,668
200 192,320 300,247
P99 0.094891903 0.071254137

@Meldiron Meldiron changed the title [WIP] Move createDocument from api to worker Move createDocument from api to worker Oct 14, 2024
@Meldiron Meldiron merged commit 8a5a160 into 1.6.x Oct 14, 2024
26 checks passed
@Meldiron Meldiron deleted the fix-move-write-execution-to-worker branch October 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0