fix: builds worker new structure #8843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ Benchmark results
⚡ Benchmark Comparison
|
| { | ||
| public static function getName(): string | ||
| { | ||
| return 'builds'; |
There was a problem hiding this comment.
Shouldn't it be buildFunctions? And it is common for both functions and sites, then we need to move it out of Functions directory.
| throw new \Exception('Entrypoint for your Appwrite Function is missing. Please specify it when making deployment or update the entrypoint under your function\'s "Settings" > "Configuration" > "Entrypoint".', 500); | ||
| } | ||
|
|
||
| $version = $resource->getAttribute('version', 'v2'); |
There was a problem hiding this comment.
We probably need to add version for sites collection, since we would want to use v4 for sites
| // todo: fix for sites using frameworks | ||
| $key = $resource->getAttribute('runtime'); | ||
| $runtime = $runtimes[$key] ?? null; | ||
| if (\is_null($runtime)) { |
There was a problem hiding this comment.
Sites do not have a runtime. They have a framework. We need to find buildRuntime and serveRuntime using a config file.
| throw new \Exception('Deployment not found', 404); | ||
| } | ||
|
|
||
| if (empty($deployment->getAttribute('entrypoint', ''))) { |
There was a problem hiding this comment.
Entrypoint will be empty for sites. Please add a condition to check this only for functions.
vermakhushboo
approved these changes
Oct 22, 2024
Security Scan Results for PRDocker Image Scan Results🎉 No vulnerabilities found! Source Code Scan Results🎉 No vulnerabilities found! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist