8000 Feat: Static sites by Meldiron · Pull Request #8860 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat: Static sites #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2024
Merged

Feat: Static sites #8860

merged 4 commits into from
Oct 26, 2024

Conversation

Meldiron
Copy link
Contributor

What does this PR do?

Ensures "Static" framework works for Sites

Test Plan

  • Manual QA

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@Meldiron Meldiron marked this pull request as draft October 25, 2024 17:26
@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 25, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 25, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,217
  • Requests with 200 status code: 219,042
  • P99 latency: 0.089731229

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,217 2,119
200 219,042 381,552
P99 0.089731229 0.075365101

@Meldiron Meldiron marked this pull request as ready for review October 26, 2024 16:57
Meldiron
Meldiron commented Oct 26, 2024
View reviewed changes
Copy link
Contributor Author
@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Meldiron Meldiron merged commit a171e17 into feat-sites Oct 26, 2024
22 of 24 checks passed
@Meldiron Meldiron deleted the feat-sites-static branch October 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meldiron @TorstenDittmann
0