8000 Fix Migrations having source creds being overwritten and add Migration tests by PineappleIOnic · Pull Request #8897 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Migrations having source creds being overwritten and add Migration tests #8897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2024
Merged

Fix Migrations having source creds being overwritten and add Migration tests #8897

merged 7 commits into from
Oct 31, 2024

Conversation

PineappleIOnic
Copy link
Contributor
@PineappleIOnic PineappleIOnic commented Oct 30, 2024 •
edited
Loading

What does this PR do?

This PR fixes a bug where the source credentials would be overwritten with Appwrite's own. It also introduces tests for E2E Appwrite migrations

Test Plan

Tests have now been added for E2E Appwrite migrations.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@PineappleIOnic PineappleIOnic changed the base branch from main to 1.6.x October 30, 2024 05:24
@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 30, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 30, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,313
  • Requests with 200 status code: 236,415
  • P99 latency: 0.083967067

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,313 2,177
200 236,415 392,013
P99 0.083967067 0.070861173

@PineappleIOnic PineappleIOnic changed the title Fix Migrations having source creds being overwritten Fix Migrations having source creds being overwritten and add Migration tests Oct 31, 2024
@PineappleIOnic PineappleIOnic marked this pull request as ready for review October 31, 2024 06:31
@abnegate abnegate merged commit aaf67df into 1.6.x Oct 31, 2024
27 checks passed
@abnegate abnegate deleted the fix-migrations-using-dst-creds branch October 31, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PineappleIOnic @abnegate
0