8000 Send migration errors individually by PineappleIOnic · Pull Request #8959 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Send migration errors individually #8959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 14, 2024
Merged

Send migration errors individually #8959

merged 7 commits into from
Nov 14, 2024

Conversation

PineappleIOnic
Copy link
Contributor

What does this PR do?

This PR makes it so that migration errors get fired individually against the logger

Test Plan

I added purposeful exceptions into migration lib locally and tested this works as intended.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@PineappleIOnic PineappleIOnic changed the base branch from main to 1.6.x November 12, 2024 02:30
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 12, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libecpg 16.3-r0 CVE-2024-7348 HIGH
libecpg-dev 16.3-r0 CVE-2024-7348 HIGH
libpq 16.3-r0 CVE-2024-7348 HIGH
libpq-dev 16.3-r0 CVE-2024-7348 HIGH
postgresql16-dev 16.3-r0 CVE-2024-7348 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 12, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,272
  • Requests with 200 status code: 229,003
  • P99 latency: 0.083284201

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,272 2,135
200 229,003 384,364
P99 0.083284201 0.076179193

abnegate
abnegate reviewed Nov 12, 2024
View reviewed changes
Copy link
Member
@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this stop the "migration failed" logs being pushed as well?

abnegate
abnegate reviewed Nov 13, 2024
View reviewed changes
Copy link
Member
@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw in CLI scope we have a logError resource so that the logging function can be shared between tasks, let's add the same in worker scope and use that here

abnegate
abnegate reviewed Nov 14, 2024
View reviewed changes
@abnegate abnegate merged commit 191f884 into 1.6.x Nov 14, 2024
26 of 27 checks passed
@abnegate abnegate deleted the fix-send-migration-errors-individually branch November 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PineappleIOnic @abnegate
0