8000 chore: add audit labels to project resources by basert · Pull Request #9056 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: add audit labels to project resources #9056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore: add audit labels to project resources #9056

merged 3 commits into from
Jan 10, 2025

Conversation

basert
Copy link
Contributor
@basert basert commented Dec 2, 2024

Add missing audit labels for event and resource to projects endpoints. This allows audit-logging to track changes to projects and allows to filter by project id.

Copy link
github-actions bot commented Dec 2, 2024

✨ Benchmark results

  • Requests per second: 1,049
  • Requests with 200 status code: 188,814
  • P99 latency: 0.175179557

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,049 1,628
200 188,814 293,032
P99 0.175179557 0.071451975

@@ -1693,6 +1698,7 @@
->desc('Delete platform')
->groups(['api', 'projects'])
->label('audits.event', 'platforms.delete')
->label('audits.resource', 'project/{request.projectId}/platform/${request.platformId}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be project/{request.projectId} too? Please confirm with @christyjacob4.

@basert basert marked this pull request as ready for review December 11, 2024 11:27
Copy link
github-actions bot commented Dec 13, 2024

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@basert basert requested a review from christyjacob4 January 10, 2025 11:10
@christyjacob4 christyjacob4 merged commit 5dc04ca into 1.6.x Jan 10, 2025
63 checks passed
@christyjacob4 christyjacob4 deleted the PLA-1958 branch January 10, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0