8000 Prepare 1.6.1 release by stnguyen90 · Pull Request #9026 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prepare 1.6.1 release #9026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2024
Merged

Prepare 1.6.1 release #9026

merged 2 commits into from
Nov 27, 2024

Conversation

stnguyen90
Copy link
Contributor
@stnguyen90 stnguyen90 commented Nov 25, 2024 •
edited
Loading

What does this PR do?

  • Bump appwrite version to 1.6.1
  • Add 1.6.1 changes to CHANGES.md

Test Plan

Automated tests should pass.

In addition, the following manual tests should be performed:

docker compose build
docker tag appwrite-dev appwrite/appwrite:1.6.1
docker run -it --rm \
    --volume /var/run/docker.sock:/var/run/docker.sock \
    --volume "$(pwd)"/appwrite:/usr/src/code/appwrite:rw \
    --entrypoint=install \
    appwrite/appwrite:1.6.1

Related PRs and Issues

Parent:

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link

✨ Benchmark results

  • Requests per second: 1,112
  • Requests with 200 status code: 200,218
  • P99 latency: 0.188100782

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,112 1,899
200 200,218 341,868
P99 0.188100782 0.081298161

christyjacob4
christyjacob4 reviewed Nov 25, 2024
View reviewed changes
src/Appwrite/Migration/Migration.php
@@ -91,6 +91,7 @@ abstract class Migration
'1.5.10' => 'V20',
'1.5.11' => 'V20',
'1.6.0' => 'V21',
'1.6.1' => 'V21',
Copy link
Member

Choose a reason for hiding this comment

The reason 8000 will be displayed to describe this comment to others. Learn more.

I think the request & response filters also need an update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean creating/updating the existing filters? Or updating something to make sure the filters are used in 1.6.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to update for the filters to apply for patch versions. See

appwrite/app/controllers/general.php

Line 605 in 8e02115

if (version_compare($responseFormat, '1.6.0', '<')) {

Base automatically changed from chore-bump-console-5.2.25 to 1.6.x November 25, 2024 16:24
@stnguyen90 stnguyen90 merged commit 3500565 into 1.6.x Nov 27, 2024
60 of 61 checks passed
@christyjacob4 christyjacob4 deleted the feat-1.6.1-release-prep branch November 28, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
1.6 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @christyjacob4
0