8000 Fix delete notFound attribute by fogelito · Pull Request #9038 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix delete notFound attribute #9038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix delete notFound attribute #9038

merged 2 commits into from
Dec 2, 2024

Conversation

fogelito
Copy link
Contributor

Fix delete attribute when the attribute is not in _metadata throwing not found error.

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Copy link

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

Copy link

✨ Benchmark results

  • Requests per second: 1,155
  • Requests with 200 status code: 207,941
  • P99 latency: 0.187537938

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,155 2,050
200 207,941 368,984
P99 0.187537938 0.077197309

@fogelito fogelito requested a review from abnegate November 28, 2024 13:03
@abnegate abnegate merged commit 3ce63b3 into 1.6.x Dec 2, 2024
62 of 63 checks passed
@abnegate abnegate deleted the 1.6.x-fix-delete-attribute branch December 2, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0