8000 Add assertEventually to messaging provider logs test by ItzNotABug · Pull Request #9192 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add assertEventually to messaging provider logs test #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 10, 2025
Merged

Add assertEventually to messaging provider logs test #9192

merged 8 commits into from
Jan 10, 2025

Conversation

ItzNotABug
Copy link
Member
@ItzNotABug ItzNotABug commented Jan 8, 2025 •
edited
Loading

What does this PR do?

Adds a generic sleep to allow a write to Audits DB. This fixes an internal failing test issue with the new Audits approach.

Test Plan

Manual.

With sleep -

image

Without sleep -

image

Related PRs and Issues

N/A.

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 8, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@ItzNotABug ItzNotABug self-assigned this Jan 8, 2025
@ItzNotABug ItzNotABug changed the title Add sleep to messaging provider logs test Add assertEventually to messaging provider logs test Jan 10, 2025
@christyjacob4 christyjacob4 merged commit 619b716 into appwrite:1.6.x Jan 10, 2025
4 of 5 checks passed
@ItzNotABug ItzNotABug deleted the fix-messaging-test-for-audits branch January 10, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@eldadfux eldadfux Awaiting requested review from eldadfux

Assignees

@ItzNotABug ItzNotABug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItzNotABug @christyjacob4
0