8000 Fix: email (smtp) to multiple recipients by ChiragAgg5k · Pull Request #9243 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: email (smtp) to multiple recipients #9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix: email (smtp) to multiple recipients #9243

merged 2 commits into from
Feb 26, 2025

Conversation

ChiragAgg5k
Copy link
Member
@ChiragAgg5k ChiragAgg5k commented Jan 19, 2025 •
edited by stnguyen90
Loading

What does this PR do?

According to issue mentioned below, sending emails to multiple recipients can lead to data privacy issues.
This PR makes the messaging worker send a separate mail for each recipient if the provider is SMTP as for sendgrid and mailgun there are api endpoints for batch-sending

Note: If users want to send a single email, they can use cc, and don't want to expose emails to all recipients, they can use bcc

Test Plan

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@ChiragAgg5k ChiragAgg5k requested a review from loks0n January 19, 2025 14:50
@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 19, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libcrypto3 3.3.2-r1 CVE-2024-12797 HIGH
libecpg 16.5-r0 CVE-2025-1094 HIGH
libecpg-dev 16.5-r0 CVE-2025-1094 HIGH
libpq 16.5-r0 CVE-2025-1094 HIGH
libpq-dev 16.5-r0 CVE-2025-1094 HIGH
libssl3 3.3.2-r1 CVE-2024-12797 HIGH
openssl 3.3.2-r1 CVE-2024-12797 HIGH
openssl-dev 3.3.2-r1 CVE-2024-12797 HIGH
postgresql16-dev 16.5-r0 CVE-2025-1094 HIGH
pyc 3.12.7-r0 CVE-2024-12254 HIGH
pyc 3.12.7-r0 CVE-2024-9287 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-9287 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-9287 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-9287 HIGH
rsync 3.3.0-r0 CVE-2024-12084 CRITICAL
rsync 3.3.0-r0 CVE-2024-12085 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 19, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,046
  • Requests with 200 status code: 188,368
  • P99 latency: 0.174721391

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,046 1,666
200 188,368 299,924
P99 0.174721391 0.069917219

@ChiragAgg5k ChiragAgg5k mentioned this pull request Jan 19, 2025
Closed
loks0n
loks0n reviewed Jan 21, 2025
View reviewed changes
abnegate
abnegate reviewed Jan 29, 2025
View reviewed changes
@christyjacob4 christyjacob4 merged commit 24613c2 into 1.6.x Feb 26, 2025
29 checks passed
@christyjacob4 christyjacob4 deleted the fix-smtp branch February 26, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

@loks0n loks0n loks0n approved these changes

@stnguyen90 stnguyen90 Awaiting requested review from stnguyen90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChiragAgg5k @abnegate @loks0n @christyjacob4
0