8000 Fix build memory specifications by PineappleIOnic · Pull Request #9360 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix build memory specifications #9360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix build memory specifications #9360

merged 1 commit into from
Feb 14, 2025

Conversation

PineappleIOnic
Copy link
Contributor

What does this PR do?

This PR fixes the memory set in builds worker and creates a new test that checks the correct specification is set in both functions and builds.

Test Plan

New tests have been added to prevent future regressions.

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@PineappleIOnic PineappleIOnic changed the title Fix build memory and add tests to prevent future regressions Fix build memory specifications Feb 14, 2025
@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libcrypto3 3.3.2-r1 CVE-2024-12797 HIGH
libssl3 3.3.2-r1 CVE-2024-12797 HIGH
openssl 3.3.2-r1 CVE-2024-12797 HIGH
openssl-dev 3.3.2-r1 CVE-2024-12797 HIGH
pyc 3.12.7-r0 CVE-2024-12254 HIGH
pyc 3.12.7-r0 CVE-2024-9287 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-9287 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-9287 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-9287 HIGH
rsync 3.3.0-r0 CVE-2024-12084 CRITICAL
rsync 3.3.0-r0 CVE-2024-12085 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link

✨ Benchmark results

  • Requests per second: 1,036
  • Requests with 200 status code: 186,441
  • P99 latency: 0.176139313

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,036 1,724
200 186,441 310,282
P99 0.176139313 0.068565218

stnguyen90
stnguyen90 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor
@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job for the test too! 🔥

@stnguyen90 stnguyen90 merged commit 993c07d into 1.6.x Feb 14, 2025
29 checks passed
@stnguyen90 stnguyen90 deleted the fix-build-memory-limits branch February 18, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PineappleIOnic @stnguyen90
0