8000 Feat Disable auth methods and limit number of users. by eldadfux · Pull Request #947 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat Disable auth methods and limit number of users. #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Apr 23, 2021
Merged

Feat Disable auth methods and limit number of users. #947

merged 27 commits into from
Apr 23, 2021

Conversation

eldadfux
Copy link
Member
@eldadfux eldadfux commented Feb 28, 2021 •
edited
Loading

What does this PR do?

Adds option to control and limit your Appwrite project auth methods.

  • Disable email/password
  • Disable anon login (need to merge and apply changed)
  • Disable JWT
  • Disable team invites
  • Option to limit number of users (good for app launches + god account PR)
  • Added 2 new endpoints to the projects API to allow new settings
  • Added a new UI screen on the users section
  • Enabled 501 errors (Not Implemented) from the error handler
  • Added new e2e tests to validate new features

image

Test Plan

Added new tests.

Related PRs and Issues

#907 #385 #914 #210 #906 #472 #937

Have you read the Contributing Guidelines on issues?

Yes.

TorstenDittmann
TorstenDittmann approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor
@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

kodumbeats
kodumbeats reviewed Mar 1, 2021
View reviewed changes
kodumbeats
kodumbeats reviewed Mar 1, 2021
View reviewed changes
kodumbeats
kodumbeats suggested changes Mar 1, 2021
View reviewed changes
Copy link
Contributor
@kodumbeats kodumbeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good once we correct isPrivilegedUser 📦 👍🏻

@eldadfux eldadfux changed the base branch from dev to 0.8.x March 1, 2021 21:05
@eldadfux eldadfux marked this pull request as ready for review March 1, 2021 21:05
kodumbeats
kodumbeats approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor
@kodumbeats kodumbeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@eldadfux eldadfux mentioned this pull request Mar 17, 2021
Merged
@TorstenDittmann
Copy link
Contributor

Resolved conflicts and synced this branch 👍🏻

@eldadfux eldadfux merged commit c80ddfb into 0.8.x Apr 23, 2021
@eldadfux eldadfux deleted the feat-auth-limits branch May 15, 2021 07:07
@appwrite appwrite deleted a comment from boboB6 May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@kodumbeats kodumbeats kodumbeats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldadfux @TorstenDittmann @kodumbeats
0