8000 fix: n+1 query in users.php by loks0n · Pull Request #9437 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: n+1 query in users.php #9437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix: n+1 query in users.php #9437

wants to merge 4 commits into from

Conversation

loks0n
Copy link
Member
@loks0n loks0n commented Mar 4, 2025 •
edited
Loading
  • Fixed N+1 query in users.php when fetching team memberships by batching team lookups
    into a single query

@loks0n loks0n changed the base branch from main to 1.6.x March 4, 2025 14:49
@loks0n loks0n changed the title fix db perf improvements fix: db perf improvements Mar 4, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 4, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

🎉 No vulnerabilities found!

Source Code Scan Results

🎉 No vulnerabilities found!

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented Mar 4, 2025

Open in Stackblitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@9437

commit: 78bbac2

@loks0n loks0n changed the title fix: db perf improvements fix: n+1 query in users.php Mar 4, 2025
@loks0n loks0n requested a review from abnegate March 4, 2025 14:59
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 4, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,038
  • Requests with 200 status code: 186,818
  • P99 latency: 0.173989314

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,038 1,201
200 186,818 216,232
P99 0.173989314 0.153218354

@loks0n loks0n closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate Awaiting requested review from abnegate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loks0n
0