chore: fix console audits delete #9547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
abnegate
reviewed
Mar 20, 2025
✨ Benchmark results
⚡ Benchmark Comparison
|
7f1f5b3 to
5eb7c36
Compare
abnegate
reviewed
Mar 21, 2025
53bcf9f to
7c795da
Compare
| @@ -389,6 +390,8 @@ services: | |||
| - _APP_DATABASE_SHARED_TABLES | |||
| - _APP_DATABASE_SHARED_TABLES_V1 | |||
| - _APP_EMAIL_CERTIFICATES | |||
| - _APP_MAINTENANCE_RETENTION_AUDIT | |||
| - _APP_MAINTENANCE_RETENTION_AUDIT_CONSOLE | |||
There was a problem hiding this comment.
we only need to add this to the maintenance task and deletes worker right?
abnegate
approved these changes
Mar 21, 2025
christyjacob4
approved these changes
Mar 21, 2025
stnguyen90
reviewed
Mar 21, 2025
Comment on lines
221
to
226
| Server::setResource('auditRetention', function () { | ||
| return DateTime::addSeconds(new \DateTime(), -1 8000 * System::getEnv('_APP_MAINTENANCE_RETENTION_AUDIT', 1209600)); | ||
| return [ | ||
| 'project' => DateTime::addSeconds(new \DateTime(), -1 * System::getEnv('_APP_MAINTENANCE_RETENTION_AUDIT', 1209600)), // 14 days | ||
| 'console' => DateTime::addSeconds(new \DateTime(), -1 * System::getEnv('_APP_MAINTENANCE_RETENTION_AUDIT_CONSOLE', 15778800)) // 6 months | ||
| ]; | ||
| }); |
There was a problem hiding this comment.
Isn't the typical way we do this is to depend on the project? So if the project is console, it'd be one value. if the project is not, it would be another value. For example:
Lines 347 to 349 in 29ea03b
Also, this should probably depend on the org because the retention should really be different based on the plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses dbForPlatform for deleting console audits, and adds new retention for it. default is 6 months.
Test Plan
Related PRs and Issues
Checklist