8000 Add events for functions and executions by kodumbeats · Pull Request #971 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add events for functions and executions #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 17, 2021
Merged

Add events for functions and executions #971

merged 11 commits into from
Mar 17, 2021

Conversation

kodumbeats
Copy link
Contributor
@kodumbeats kodumbeats commented Mar 11, 2021 •
edited
Loading

What does this PR do?

This PR adds events for the following actions in the API:

  • functions.create
  • functions.update
  • functions.delete
  • functions.tags.create
  • functions.tags.update
  • functions.tags.delete
  • functions.executions.create

It also adds the following event in the Functions worker:

  • functions.executions.update

Test Plan

  • Create webhook for new events
  • Trigger the events through the console
  • Observe logs for appwrite-worker-webhooks for webhook triggers
  • Observe webhook target endpoint (request-catcher in testing)

Todo

  • Create events
  • Create webhook tests
  • Update changelog

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

yes.

@TorstenDittmann
Copy link
Contributor

functions.executions.update is probably the most important one for realtime 🤔

This must probably be triggered from the functions worker 👍

@kodumbeats
Copy link
Contributor Author

functions.executions.update is probably the most important one for realtime

This must probably be triggered from the functions worker

So I understand, you'd like the functions worker to emit the functions.executions.update event when a function's status flips (from working to completed, for instance)?

@TorstenDittmann
Copy link
Contributor

Yes, this way we can listen to execution completion over realtime ☺️

@kodumbeats kodumbeats marked this pull request as ready for review March 12, 2021 23:14
TorstenDittmann
TorstenDittmann reviewed Mar 17, 2021
View reviewed changes
TorstenDittmann
TorstenDittmann approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor
@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻 awesome work @kodumbeats 👏🏻

@eldadfux eldadfux changed the base branch from dev to 0.8.x March 17, 2021 20:53
@eldadfux eldadfux merged commit 38ef5ce into 0.8.x Mar 17, 2021
@eldadfux
Copy link
Member

Great work @kodumbeats !!

@eldadfux eldadfux deleted the feat-functions-and-executions-events branch March 24, 2021 07:14
@eldadfux eldadfux mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kodumbeats @TorstenDittmann @eldadfux
0