refactor: maintenance task to run at a specific time #9734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
Comment on lines
+45
to
+59
| $now = new \DateTime(); | ||
| $now->setTimezone(new \DateTimeZone(date_default_timezone_get())); | ||
| $next = new \DateTime($now->format("Y-m-d $jobInitTime")); | ||
| $next->setTimezone(new \DateTimeZone(date_default_timezone_get())); | ||
| $delay = $next->getTimestamp() - $now->getTimestamp(); | ||
|
|
||
| /** | ||
| * If time passed for the target day. | ||
| */ | ||
| if ($delay <= 0) { | ||
| $next->add(\DateInterval::createFromDateString('1 days')); | ||
| $delay = $next->getTimestamp() - $now->getTimestamp(); | ||
| } | ||
|
|
||
| Console::info('Setting loop start time to ' . $next->format("Y-m-d H:i:s.v") . '. Delaying for ' . $delay . ' seconds.'); |
There was a problem hiding this comment.
this will need some modifying since we no longer need the _APP_MAINTENANCE_DELAY variable
There was a problem hiding this comment.
just realized the variable was just being overriden so its all good now!
christyjacob4
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the maintenance task to only run at a specific time as the container might be restarted at random times depending on the setup, leading to issues.
Test Plan
Related PRs and Issues
Checklist