8000 added checking for encrypt and plan allowing encryption of string att… by ArnabChatterjee20k · Pull Request #9841 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added checking for encrypt and plan allowing encryption of string att… #9841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2025
Merged

added checking for encrypt and plan allowing encryption of string att… #9841

merged 6 commits into from
May 21, 2025

Conversation

ArnabChatterjee20k
Copy link
Contributor
@ArnabChatterjee20k ArnabChatterjee20k commented May 21, 2025 •
edited
Loading

…ribute

What does this PR do?

Passing
image

Failing
image

If the encrypt parameter is true but $plan['databasesAllowEncrypt'] is false or missing, throw a 400 with message 'Encrypted string attributes are not available on your plan. Please upgrade to create encrypted string attributes.'

Test Plan

Added tests in the testCreateAttribute

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • New Features
    • Added plan-based restrictions for creating encrypted string attributes in the database API. Users without encryption support will be prompted to upgrade when attempting to enable encryption.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 21, 2025 •
edited
Loading

Warning

Rate limit exceeded

@ArnabChatterjee20k has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 82fd855 and c4df1c8.

📒 Files selected for processing (1)
  • app/controllers/api/databases.php (1 hunks)

Walkthrough

A plan-based permission check was added to the API endpoint for updating string attributes in databases, restricting encrypted attribute updates to plans with the appropriate permission. The endpoint’s function signature was updated to receive the plan context. Correspondingly, a trailing comma was removed in an existing test’s attribute update payload.

Changes

File(s) Summary
app/controllers/api/databases.php Added plan-based permission check for encrypted string attribute updates; updated endpoint signature to inject plan array.
tests/e2e/Services/Databases/DatabasesCustomServerTest.php Removed trailing comma after 'encrypt' => true in the attribute update payload in an existing test.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API
    participant PlanChecker

    Client->>API: PATCH /v1/databases/:dbId/collections/:colId/attributes/string/:key (with encrypt flag)
    API->>PlanChecker: Check if plan allows databasesAllowEncrypt
    alt Plan allows encryption
        API->>API: Proceed to update encrypted attribute
    else Plan does not allow encryption
        API-->>Client: Throw error (encryption not available, suggest upgrade)
    end
Loading

Poem

In fields of code where data’s spun,
A plan decides if encryption’s done.
If your plan’s the key, encrypt with cheer,
Else a gentle nudge to upgrade’s near.
Tests trimmed neat, commas gone,
Secure and tidy, hopping on!
🐇🔐✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 21, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

abnegate
abnegate reviewed May 21, 2025
View reviewed changes
abnegate
abnegate reviewed May 21, 2025
View reviewed changes
@abnegate abnegate merged commit eab446a into appwrite:main May 21, 2025
37 checks passed
abnegate added a commit that referenced this pull request May 23, 2025
@abnegate
Merge pull request #9841 from ArnabChatterjee20k/dat-532
d27dba0 
added checking for encrypt and plan allowing encryption of string att…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate abnegate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnabChatterjee20k @abnegate
0