8000 Fix: unlimited deployment size by Meldiron · Pull Request #9866 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: unlimited deployment size #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Fix: unlimited deployment size #9866

merged 1 commit into from
May 22, 2025

Conversation

Meldiron
Copy link
Contributor
@Meldiron Meldiron commented May 22, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Summary by CodeRabbit

  • Bug Fixes
    • Improved file and build size validation for functions and sites to allow unlimited size when the configured size limit is set to zero. Exceptions for exceeding size limits are now only triggered if a non-zero limit is specified.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 22, 2025 •
edited
Loading

Walkthrough

The changes update size limit validation logic in deployment and build processes for functions and sites. Now, exceptions for exceeding file or build size are only thrown if the configured size limit is non-zero, allowing unlimited size when the limit is set to zero. No public APIs or exported entities were altered.

Changes

File(s) Change Summary
src/Appwrite/Platform/Modules/Functions/Http/Deployments/Create.php Modified file size validation to only throw exceptions if the size limit is non-zero.
src/Appwrite/Platform/Modules/Functions/Workers/Builds.php Updated repository and build size checks to skip exceptions when the respective size limit is zero.
src/Appwrite/Platform/Modules/Sites/Http/Deployments/Create.php Changed file size validation to bypass errors if the site size limit is zero.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant API
    participant Validator

    User->>API: Upload deployment file
    API->>Validator: Validate file size
    alt Size limit > 0
        Validator-->>API: Throw exception if size exceeded
    else Size limit == 0
        Validator-->>API: Allow unlimited size
    end
    API->>User: Success or error response
Loading

Possibly related PRs

Poem

In code we check, in bytes we trust,
But now a zero lifts the dust—
No limits bind the files you send,
For size is boundless, rules now bend!
A rabbit hops with glee so bright,
Unlimited uploads, what a delight! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4adea70 and b4f5af8.

📒 Files selected for processing (3)
  • src/Appwrite/Platform/Modules/Functions/Http/Deployments/Create.php (1 hunks)
  • src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (2 hunks)
  • src/Appwrite/Platform/Modules/Sites/Http/Deployments/Create.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (4)
src/Appwrite/Platform/Modules/Functions/Http/Deployments/Create.php (1)

185-187: Looks good - size check now respects zero limit value

The code now correctly checks if the function size limit is not zero before throwing an exception when file size validation fails. This change enables unlimited deployment sizes when the limit is explicitly set to zero.

src/Appwrite/Platform/Modules/Sites/Http/Deployments/Create.php (1)

186-188: Looks good - size check now respects zero limit value

The code now correctly checks if the site size limit is not zero before throwing an exception when file size validation fails. This change enables unlimited deployment sizes when the limit is explicitly set to zero.

src/Appwrite/Platform/Modules/Functions/Workers/Builds.php (2)

489-491: Looks good - repository size check now respects zero limit value

The code now correctly checks if the size limit is not zero before throwing an exception when repository directory size exceeds the limit. This change enables unlimited repository sizes when the limit is explicitly set to zero.

819-821: Looks good - build size check now respects zero limit value

The code now correctly checks if the build size limit is not zero before throwing an exception when build size exceeds the limit. This change enables unlimited build sizes when the limit is explicitly set to zero.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@Meldiron Meldiron merged commit 57ee69a into main May 22, 2025
38 checks passed
@github-actions GitHub Actions
Copy link

✨ Benchmark results

  • Requests per second: 896
  • Requests with 200 status code: 161,414
  • P99 latency: 0.215431051

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 896 1,159
200 161,414 208,707
P99 0.215431051 0.160381077

@coderabbitai coderabbitai bot mentioned this pull request May 26, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meldiron @christyjacob4
0