fix: apns provider key file upload input #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't hardcode the upload dropzone to be for service account JSON files only.
|
One issue I'm noticing is the popover isn't updating correct. For example, after opening the APNS Team ID popover and then switching to FCM, the 1st popover shows the Team ID popover: Any ideas? |
could be a reactivity issue. maybe try with a |
ItzNotABug
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't hardcode the upload dropzone to be for service account JSON files only.
Fixes #2045
Test Plan
Tested locally:
FCM:
APNS:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes