capture: fixes and tests #4016
Merged
capture: fixes and tests #4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivagman
approved these changes
May 5, 2024
There was a problem hiding this comment.
Good catch, LGTM,
For some reason, the github actions to run tests on a new PR are not working as expected, so we can't see if the new tests work as they should.
Let's wait to see the new tests pass as expected before merging this PR.
We also need to backport it to v0.21.0
Commit 3ddf73d changed various probe_read calls to probe_read_kernel. However, io capture relies on reading userspace buffers, as such the pointers being read are userspace pointers. Therefore the relevant calls in some of these changes, affecting IO capture, were changed to probe_read_user.
d92f13f to
721aad7
Compare
Add an e2e instrumentation test for the vfs_writev event. Due to the event being broken on some kernels, it is currently disabled (missing in declaration in pr.yaml).
7251dd1 to
d192a1e
Compare
d192a1e to
858b7a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
d92f13f tests(integration): add capture tests
8ad9959 tests(inst): add vfs_writev test
bb7cd56 fix: restore io capture output
bb7cd56 fix: restore io capture output
2. Explain how to test it
OR
tracee -c read=/home/ubuntu/output* -c write=/home/ubuntu/output*echo Hello > /home/ubuntu/output.txtcat /home/ubuntu/output.txt/tmp/tracee/out/hostfor the relevant files and confirm their content (both should beHello)3. Other comments
Resolve #4013