Fix Integration Tests #4157
Merged
Fix Integration Tests #4157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc00c99 to
b22f771
Compare
Test_EventsDependencies overrides the default logger to capture the logs and check them as part of the test. Before it was synced to pass in the github actions, what wasn't happening locally or in a different environment. Since the logger was not thread safe, it was causing the test to fail (data race). That forced the previous commit which turned Logger into a thread safe logger. This fixes the problem refactoring it to override and restore the logger in the correct steps.
This test was failing when other tests were run before it and failed, tracee running was not stopped and some garbage was left in the system. Two major changes were made: 1. Do not fail the test before stopping tracee. 2. Always remove capture files after the test (do cleanup).
b22f771 to
74bfd7d
Compare
yanivagman
reviewed
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4156
1. Explain what the PR does
74bfd7d fix(tests): refactor Test_TraceeCapture
4e1f899 fix(tests): Test_EventsDependencies
f493e28 chore: turn logger thread-safe
74bfd7d fix(tests): refactor Test_TraceeCapture
4e1f899 fix(tests): Test_EventsDependencies
2. Explain how to test it
3. Other comments