8000 fix(build): add the include to 3rdparty libbpf during libbpfgo compilation by rscampos · Pull Request #4186 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(build): add the include to 3rdparty libbpf during libbpfgo compilation #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(build): add the include to 3rdparty libbpf during libbpfgo compilation #4186

merged 1 commit into from
Jul 15, 2024

Conversation

rscampos
Copy link
Collaborator
@rscampos rscampos commented Jul 12, 2024 •
edited
Loading

1. Explain what the PR does

b1e17b7 fix(build): include libbpf during libbpfgo compilation

An issue appears when we try to compile libbpfgo on an older kernel that
doesn't have the XDP_FLAGS_REPLACE defined in
/usr/include/linux/if_link.h. To overcome this, it is necessary to
include the directory of libbpf under 3rdparty during the compilation,
since install_uapi_headers doesn't install if_link.h.

2. Explain how to test it

3. Other comments

Thank you @geyslan for the guidance through this issue.

@rscampos rscampos requested a review from geyslan July 12, 2024 20:09
@rscampos rscampos force-pushed the fix_build_process_libbpf branch from c9408fc to 8392bae Compare July 12, 2024 20:10
geyslan
geyslan reviewed Jul 15, 2024
View reviewed changes
@rscampos
fix(build): include libbpf during libbpfgo compilation
b1e17b7 
An issue appears when we try to compile libbpfgo on an older kernel that
doesn't have the XDP_FLAGS_REPLACE defined in
/usr/include/linux/if_link.h. To overcome this, it is necessary to
include the directory of libbpf under 3rdparty during the compilation,
since install_uapi_headers doesn't install if_link.h.
@rscampos rscampos force-pushed the fix_build_process_libbpf branch from 8392bae to b1e17b7 Compare July 15, 2024 14:39
geyslan
geyslan approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member
@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscampos rscampos merged commit 4154ab0 into aquasecurity:main Jul 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan approved these changes

Assignees

@rscampos rscampos

Labels
area/build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rscampos @geyslan
0