fix(tests): possible out of range in integration #4305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd4862a to
0c1d041
Compare
0c1d041 to
ac47cab
Compare
ExpectAllInOrderSequentially might try to access an index ou 8000 t of range depending on the number of events that are being checked. More about in issue aquasecurity#4255.
Two test cases were using ExpectAllInOrderSequentially helper function and passing by luck, since they emit more events than expected only beyond the expected events boundary. For that cases we should use ExpectAtLeastOneForEach helper function instead.
ac47cab to
5cf2d9d
Compare
|
/fast-forward |
|
Triggered from #4305 (comment) by @geyslan. Trying to fast forward Target branch ( commit bae153278e76f10082bd40533fbd2c3e4140fb17 (HEAD -> main, origin/main, origin/HEAD)
Author: Geyslan Gregório <geyslan@gmail.com>
Date: Tue Oct 15 11:33:18 2024 -0300
chore(performance): update tracee dashboardPull request ( commit 5cf2d9d1b5a9b3ffde3f4d279e018eef5c6de8cd (pull_request/4255-fix-expect-all-in-order)
Author: Geyslan Gregório <geyslan@gmail.com>
Date: Wed Sep 25 12:02:29 2024 -0300
fix(tests): use ExpectAtLeastOneForEach
Two test cases were using ExpectAllInOrderSequentially helper function
and passing by luck, since they emit more events than expected only
beyond the expected events boundary.
For that cases we should use ExpectAtLeastOneForEach helper function
instead.Fast forwarding $ git push origin 5cf2d9d1b5a9b3ffde3f4d279e018eef5c6de8cd:main
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote:
remote: - At least 1 approving review is required by reviewers with write access.
To https://github.com/aquasecurity/tracee.git
! [remote rejected] 5cf2d9d1b5a9b3ffde3f4d279e018eef5c6de8cd -> main (protected branch hook declined)
error: failed to push some refs to 'https://github.com/aquasecurity/tracee.git' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4255
1. Explain what the PR does
5cf2d9d fix(tests): use ExpectAtLeastOneForEach
34be7e0 fix(tests): possible out of range in integration
2. Explain how to test it
3. Other comments