8000 fix(epbf): fix handling of compat tasks in syscall checkers by oshaked1 · Pull Request #4562 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(epbf): fix handling of compat tasks in syscall checkers #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix(epbf): fix handling of compat tasks in syscall checkers #4562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/ebpf/c/tracee.bpf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5320,6 +5320,13 @@ statfunc void check_suspicious_syscall_source(void *ctx, struct pt_regs *regs, u
if (vma_is_file_backed(vma))
return;

// In 32-bit compat mode, syscalls may be invoked by calling into a VDSO provided
// syscall handler (the vsyscall mechanism).
// Even the 64-bit VDSO may invoke syscalls, as a fallback mechanism.
// In such cases, we don't know where was the code that called into the VDSO.
if (vma_is_vdso(vma))
return;

// Build a key that identifies the combination of syscall,
// source VMA and process so we don't submit it multiple times
syscall_source_key_t key = {.syscall = syscall,
Expand Down Expand Up @@ -5410,6 +5417,12 @@ int BPF_KPROBE(syscall_checker)

// Get syscall ID
u32 syscall = get_syscall_id_from_regs(regs);
if (is_compat((struct task_struct *) bpf_get_current_task())) {
u32 *id_64 = bpf_map_lookup_elem(&sys_32_to_64_map, &syscall);
if (id_64 == NULL)
return 0;
syscall = *id_64;
}

if (bpf_map_lookup_elem(&suspicious_syscall_source_syscalls, &syscall) != NULL)
check_suspicious_syscall_source(ctx, regs, syscall);
Expand Down
0