10000 Add security_task_prctl event by oshaked1 · Pull Request #4583 · aquasecurity/tracee · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add security_task_prctl event #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add security_task_prctl event #4583

wants to merge 2 commits into from
+395 −9

Conversation

oshaked1
Copy link
Contributor

No description provided.

@oshaked1 oshaked1 marked this pull request as draft February 12, 2025 13:50
@oshaked1 oshaked1 force-pushed the security_task_prctl branch from 768f27a to 2d70e31 Compare February 12, 2025 14:04
@oshaked1 oshaked1 marked this pull request as ready for review February 12, 2025 16:01
@oshaked1 oshaked1 force-pushed the security_task_prctl branch 5 times, most recently from bb5dd35 to e73cf9a Compare February 17, 2025 11:46
@oshaked1 oshaked1 force-pushed the security_task_prctl branch from e73cf9a to ec0be42 Compare February 25, 2025 13:16
ShohamBit
ShohamBit approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor
@ShohamBit ShohamBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member
geyslan commented Mar 6, 2025

Getting here soon.

geyslan
geyslan requested changes Mar 6, 2025
View reviewed changes
Copy link
Member
@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. I've put some thoughts. It will be required other PR to change proto (grpc api) accommodating this new event.

geyslan
geyslan reviewed Mar 6, 2025
View reviewed changes
@oshaked1 oshaked1 force-pushed the security_task_prctl branch 5 times, most recently from f24e6f1 to 55391ff Compare March 11, 2025 16:05
geyslan
geyslan approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member
@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oshaked1 oshaked1 force-pushed the security_task_prctl branch from 55391ff to fc47874 Compare March 17, 2025 15:22
@ShohamBit
Copy link
Contributor

@oshaked1 @geyslan required to rerun the test.

@oshaked1 oshaked1 force-pushed the security_task_prctl branch 2 times, most recently from c149f37 to 91a4eaf Compare March 24, 2025 13:28
@oshaked1 oshaked1 force-pushed the security_task_prctl branch from 91a4eaf to d57ddfb Compare March 24, 2025 13:29
@oshaked1
Copy link
Contributor Author

@NDStrahilevitz I added a commit that updates the translation table

@NDStrahilevitz
Copy link
Collaborator

Please wait with merging this after #4353. I will +1 after aligning with it.

@NDStrahilevitz
Copy link
Collaborator

Please wait with merging this after #4353. I will +1 after aligning with it.

Ok, now that its merged, just this remains.

@oshaked1 oshaked1 force-pushed the security_task_prctl branch from d57ddfb to ae891af Compare May 5, 2025 09:48
@oshaked1
chore(grpc): update translation table
1910ea7 
For security_task_prctl event
@oshaked1 oshaked1 force-pushed the security_task_prctl branch from ae891af to 1910ea7 Compare May 5, 2025 11:20
@oshaked1
Copy link
Contributor Author
oshaked1 commented May 5, 2025

@NDStrahilevitz aligned with your PR

NDStrahilevitz
NDStrahilevitz approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of the alignment. Have you tested that it renders as you expect?

@oshaked1
Copy link
Contributor Author
oshaked1 commented May 5, 2025

Yes it works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan approved these changes

@NDStrahilevitz NDStrahilevitz NDStrahilevitz approved these changes

@ShohamBit ShohamBit ShohamBit approved these changes

Assignees

@oshaked1 oshaked1

Labels
area/api area/build area/ebpf area/events area/grpc milestone/v0.24.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oshaked1 @geyslan @ShohamBit @NDStrahilevitz
0