Add event filter #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivagman
reviewed
Nov 13, 2019
tracee/container_tracer.py
Outdated
| @@ -679,6 +683,25 @@ def open_flags_to_str(flags): | |||
|
|
|||
| return f_str | |||
|
|
|||
| # Given the list of event names the user wants to trace, get_kprobes() returns the | |||
| # - syscalls we want kprobes for (including the essential ones needed for racee to work) | |||
yanivagman
reviewed
Nov 13, 2019
|
|
||
| log.info(json.dumps(data)) | ||
| self.events.append(data) | ||
| if eventname in self.events_to_trace: |
There was a problem hiding this comment.
I don't think this is needed. If no kprobe attached for an event, we will never receive that event from the kernel
There was a problem hiding this comment.
This is to avoid tracing out the “essential_syscalls” (execve/execveat) if they aren’t selected
yanivagman
reviewed
Nov 13, 2019
yanivagman
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-e/--events-to-traceoption allowing user to specify the syscalls and events to be shown in the trace.For example:
tracee -e cap_capable,execveshows only cap_capable and execve events in the outputDefault is to include all events (can also be explicitly specified with
-e all)